Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

78 cannot replace variables with values of type map from another class sometimes #79

Conversation

lukasjarosch
Copy link
Owner

No description provided.

@andaryjo
Copy link
Collaborator

this is actually what I tried as well, thinking "if it is type map[string]interface{}, simply support map[string]interface{}" :D

in our testing this worked sometimes but would for some unknown reason result in infinite loops other times. But likely I messed something up. I will try out this fix first thing tomorrow.

@andaryjo
Copy link
Collaborator

I can also see you removed the duplicate replaceVariables function. It took @alxndr13 and me some time to figure out what that was about. :D

@lukasjarosch
Copy link
Owner Author

@andaryjo Hm, I've not come across an endless loop. I must admit that I've probably not tested as extensively as you did, so I'm looking forward to your results.

@lukasjarosch
Copy link
Owner Author

Yeah, the duplicate did somehow end up in main. Really sorry about that 😔

@andaryjo
Copy link
Collaborator

Tested, and with this fix now everything seems to work flawlessly 🚀

@alxndr13
Copy link
Collaborator

alxndr13 commented Feb 14, 2024

Tested, and with this fix now everything seems to work flawlessly 🚀

I can still trigger the error, lets talk about this once you're awake again 😂

Edit: Nevermind, can't trigger it again. what the hell

@lukasjarosch lukasjarosch merged commit 15bf3bb into main Feb 14, 2024
18 checks passed
@lukasjarosch lukasjarosch deleted the 78-cannot-replace-variables-with-values-of-type-map-from-another-class-sometimes branch February 14, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot replace variables with values of type map from another class (sometimes)
3 participants